[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gtypist] [improvement] Fairest way to count errors in speed tes
From: |
Felix Natter |
Subject: |
Re: [bug-gtypist] [improvement] Fairest way to count errors in speed test. |
Date: |
Thu, 11 Sep 2014 19:17:45 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) |
Tim Marston <address@hidden> writes:
> Hi Felix, Alain,
hi Tim,
hi Alain,
> On Sat, Sep 06, 2014 at 08:17:24PM +0200, Felix Natter wrote:
>> Sorry for the very late reply - I was busy with my dayjob and another
>> open source project.
>
> Yeah, me too. :o)
>
>> > So this patch aims at providing an errors rate calculation that
>> > counts only the errors not fixed when the user reaches the end of
>> > the exercise.
>>
>> To me the patch looks good, but before I apply it I'd like to ask Tim if
>> he wants this to take effect unconditionally (i.e. without a cli/config
>> file option).
>> @Tim: What do you think? (I think it's ok without an option).
>
> No, this looks good to me too. It doesn't change the way gtypist
> currently behaves, it only adds an extra feature. I like it!
Well, it does change the behavior, did you want to say "only a minor
change"?
> I think we should add it to 2.10 branch, though, since it's a new
> feature.
Sure, pushed. Again, thanks for the contribution!
Best Regards,
--
Felix Natter