Re: Busy loop in menus

[Mihai Gătejescu]

Hello Petteri,

Thank you for contacting us.

I wasn't able to reproduce the issue, but I thought it was a good idea
to error check get_widech.
So I added the checks in our repository, in the places you mentioned.
I hope this helps.

Best regards,
Mihai

On Sat, Jan 8, 2022 at 11:33 PM Petteri Hintsanen <petterih@iki.fi> wrote:
>
> Dear gtypist maintainers,
>
> When starting gtypist without terminal input, eg. from a window manager
> by dmenu_run or some other exec mechanism, gtypist goes into a busy loop
> and consequently eats all CPU while running in the background.
>
> This happens because get_widech function returns ERR, but it is not
> checked in cursmenu.c:359 and infoview.c:274.
>
> Simple patch against current git master attached for your consideration.
>   It may not be the best solution overall, but should fix the immediate
> problem.
>
> This is on GNU/Linux machine running X11 (Xorg) and fvwm.  In fvwm's
> environment, TERM is set to "linux".
>
> Thanks,
> Petteri