Re: build fail with sun cc

[Ludovic Courtès]

Hi,

Halton Huo <address@hidden> writes:

> sun cc will build fail, just offer two patches to let sun cc build pass.

Can you be more specific as to what goes wrong?  Perhaps you could post
the error messages here?

> --- guile-1.8.1/libguile/numbers.c.orig       2007-03-22 17:46:53.913105000 
> +0800
> +++ guile-1.8.1/libguile/numbers.c    2007-03-22 17:47:09.790497000 +0800
> @@ -183,7 +183,11 @@
>  
>  
>  
> +#ifdef __GNUC__
>  SCM_C_INLINE_KEYWORD SCM
> +#else
> +SCM
> +#endif

This should not be needed.

Normally, what happens is that `configure' detects whether the C
compiler supports the `inline' keyword (or something like `__inline__').
If it does, then it defines `SCM_C_INLINE' to be that keyword; if it
doesn't, it simply `#define SCM_C_INLINE' (see `scmconfig.h').
`SCM_C_INLINE_KEYWORD', in turn, is defined to be either `SCM_C_INLINE'
or nothing (see `__scm.h').

Thus, if your compiler does not support `inline' (which your patch seems
to imply), the definition of `SCM_C_INLINE' and `SCM_C_INLINE_KEYWORD'
should yield exactly the same effect as the `#ifdef __GNUC__' you
propose to add.

So I think you should check whether your compiler supports `inline' and
look what value `configure' assigned to `SCM_C_INLINE' in `scmconfig.h'.

Thanks,
Ludovic.