Re: sleep 999 after tests

[Marijn Schouten (hkBst)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kevin Ryde wrote:
> [belated followup]
> 
> Marijn Schouten <address@hidden> writes:
>> the two sleep 999's in test-suite/tests/popen.test are really annoying. Is
>> there any good reason for them to be there?
> 
> Yep.  The parent process is supposed to see eof from the child, and in
> normal operation it then continues.  If it blocks for the whole sleep
> 999 then something has gone wrong.
> 
>> -                     "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
>> sleep 999")))))
>> +                     "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
>> sleep 1")))))
> 
> Alas, no, 1 second may not be long enough for the parent to notice what
> the child has done, depending on system load etc.
> 
> (It may be possible to make a better test, but bear in mind there was an
> actual bug in that area in the past, which the tests are trying to
> ensure doesn't raise its ugly head again.)

This test depends on networking being enabled. If networking is disabled it
should preferably not run at all, but if it runs it should fail in an
acceptable amount of time. So how about making it 30 seconds?

- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGxVhZp/VmCx0OL2wRApccAJ47fObzedfgMgpRyTmboWtt2oWvLQCeL3QZ
YJNKo1E0lcjbuRXxCE16RqU=
=BLHM
-----END PGP SIGNATURE-----