[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guile-1.8.5 test failures

From: Ludovic Courtès
Subject: Re: guile-1.8.5 test failures
Date: Mon, 02 Jun 2008 21:49:32 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)


"Peter O'Gorman" <address@hidden> writes:

> We built guile-1.8.5 on multiple machines with the native compilers and
> these patches:
> http://lists.gnu.org/archive/html/guile-devel/2008-05/msg00020.html 

I'm now convinced that we should introduce this one in the next release.

> http://lists.gnu.org/archive/html/guile-devel/2008-05/msg00017.html
> (attached patch)

This one has been committed.

> The attached patch does these things:
> 1. Fix a build failure on hppa-hpux11.23 due to core dump during configure
>    with -luca

What's wrong with using it on non-IA64 machines?  Isn't it supposed
serve the same purpose regardless of the architecture?

> 2. Don't detect the non-posix gmtime_r and readdir_r on hpux10.20

Does defining `_POSIX_SOURCE' fix it?

FWIW, Guile 1.8.5 compiles without any problems on HP-UX 11.11.

> 3. Fix build error on Tru64 Unix with the DEC compiler, which does not like
>    the non-constant expression in case: statements, and on irix which does
>    not like the non-constant expression in the initializers in read.c and
>    print.c. (yes, I know - yuck).

But these are constants!  The modifications you suggest are quite
harmless but intrusive.  The one in `{print,read}.c' (changing
`SCM_BOOL_F' to `scm_tc8_flag') makes the code harder to read and
fragile.  So I'm not sure that would be a good idea to change it.

> 4. #define LONG_LONG_MIN and LONG_LONG_MAX id the are not available
>    (unfortunately I can not remember which system this was on).

Eh, can you remember now?  :-)

> 5. Some older systems have inttypes.h that does not define PRIiMAX.

OK, I checked it in.

> 6. xlc on AIX 4.3 does not like 'static const char s_scm_hash_fold[];', we
>    moved the code around to make it unnecessary.

Hmm, what does it mean that it doesn't like it?  It's valid C, right?

(It's always annoying to move code around because then it makes it
harder to track the origin of a change, e.g., via `git-blame'.)

> 7. Tru64 Unix has headers that #define except, change it to something else
>    in deprecated.c.

Checked in.

> 8. Small patch to guile-config.in to put -lguile after -L/path/to/lib (we
>    did not have a problem with this yet, but the linker on at least HP-UX
>    requires the order be correct).

Checked in.

> With all of these patches we did not have too much trouble except for
> ia64-hp-hpux11.23 and Tru64 Unix 5.1.

OK, we'll see that later if you don't mind.  :-)

BTW, if you plan to contribute further changes, you will need to assign
your copyright to the FSF.  We can work this out off-line if you want.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]