[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: -Wundef warning in striconveh.h

From: Eric Blake
Subject: Re: -Wundef warning in striconveh.h
Date: Thu, 17 Mar 2011 08:05:17 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 03/17/2011 04:20 AM, Andy Wingo wrote:
> Hello,
> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef,
> or something.

Not a bug in gnulib,

> Building Guile a contributor got this warning:

but in guile.  Gnulib specifically documents that -Wundef is
incompatible with gnulib modules, and that our coding style is
deliberate.  -Wundef only catches portability problems for ancient
(non-C89) compilers, and gnulib requires C89 as a bare minimum.  While
you are free to use it for the rest of your project, you need to avoid
it while compiling gnulib (or at least ignore the warnings and avoid

The coreutils project demonstrates how to have two different set of
warning flags appended to AM_CFLAGS: a looser set for the gnulib
subdirectory, and a stricter set for the rest of the project.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]