[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13074: VM Segfaults with Bad `Call' Instruction
From: |
Ludovic Courtès |
Subject: |
bug#13074: VM Segfaults with Bad `Call' Instruction |
Date: |
Wed, 05 Dec 2012 15:10:10 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Hi Noah,
Noah Lavine <address@hidden> skribis:
> diff --git a/libguile/vm-i-system.c b/libguile/vm-i-system.c
> index 7153ab5..dff2ab2 100644
> --- a/libguile/vm-i-system.c
> +++ b/libguile/vm-i-system.c
> @@ -793,7 +793,9 @@ VM_DEFINE_INSTRUCTION (55, call, "call", 1, -1, 1)
>
> VM_HANDLE_INTERRUPTS;
>
> - if (SCM_UNLIKELY (!SCM_PROGRAM_P (program)))
> + if (SCM_UNLIKELY (program == NULL))
> + goto vm_error_bad_instruction;
> + else if (SCM_UNLIKELY (!SCM_PROGRAM_P (program)))
> {
> if (SCM_STRUCTP (program) && SCM_STRUCT_APPLICABLE_P (program))
> {
I’d rather not apply it, because it adds overhead for every call for a
situation that cannot happen when using Guile’s compiler, IIUC.
WDYT?
Thanks,
Ludo’.
- bug#13074: VM Segfaults with Bad `Call' Instruction, Noah Lavine, 2012/12/03
- bug#13074: VM Segfaults with Bad `Call' Instruction, Noah Lavine, 2012/12/04
- bug#13074: VM Segfaults with Bad `Call' Instruction,
Ludovic Courtès <=
- bug#13074: VM Segfaults with Bad `Call' Instruction, Noah Lavine, 2012/12/05
- bug#13074: VM Segfaults with Bad `Call' Instruction, Ludovic Courtès, 2012/12/05
- bug#13074: VM Segfaults with Bad `Call' Instruction, Noah Lavine, 2012/12/10
- bug#13074: VM Segfaults with Bad `Call' Instruction, Ludovic Courtès, 2012/12/11
- bug#13074: VM Segfaults with Bad `Call' Instruction, Noah Lavine, 2012/12/11