[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspeci
Mark H Weaver
bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified
Fri, 01 Mar 2013 11:10:03 -0500
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
> Daniel Hartwig <address@hidden> writes:
>> * test-suite/tests/00-socket.test:
>> * test-suite/tests/alist.test:
>> * test-suite/tests/elisp.test:
>> * test-suite/tests/encoding-iso88591.test:
>> * test-suite/tests/encoding-iso88597.test:
>> * test-suite/tests/encoding-utf8.test:
>> * test-suite/tests/hash.test:
>> * test-suite/tests/i18n.test:
>> * test-suite/tests/modules.test:
>> * test-suite/tests/ports.test:
>> * test-suite/tests/srfi-35.test: Make tests use eqv? instead of eq? when
>> comparing numbers, characters. Checked also for similar uses of
>> * test-suite/tests/vlist.test ("vhash-delete honors HASH"): Change test
>> to use eqv-ness, not eq-ness, which should not impact its purpose as
>> these two are equivalent for strings.
> I think we should apply this patch. Although we can currently rely on
> 'eq?' working properly for fixnums and characters in Guile, misuse of
> 'eq?' is widespread, and our misuse of it in our own code contributes to
> the confusion. IMO we should set a better example.
> What do other people think?
Having heard no objections over 10 days, I went ahead and pushed this.
|[Prev in Thread]
||[Next in Thread]|
- bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified,
Mark H Weaver <=