[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29001: --disable-tmpnam

From: Ludovic Courtès
Subject: bug#29001: --disable-tmpnam
Date: Sat, 21 Mar 2020 22:32:14 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Matt,

Matt Wette <address@hidden> skribis:

> "make" and "make check" succeeds on 3.0.1 / Ubuntu 18.04 / x86_64 with
> 1) --disable-tmpnam
> 2) --enable-tmpnam
> 3) neither
> This updates libguile/posix.c and configure.ac to allow extra
> configuration option --disable-tmpnam.   This is made available
> for installations that don't want to allow the insecure tmpnam
> function.  (Use mkstemp! instead.)


We should have deprecated ‘tmpnam’ before 3.0.0, it’s probably OK to do
it now.

> +AC_ARG_ENABLE(tmpnam,
> +  [  --disable-tmpnam        omit POSIX tmpnam],,
> +  enable_tmpnam=yes)

Could you use ‘AS_HELP_STRING’ as is done in some other places?  This is
the more conventional way to ensure proper formatting of ‘--help’.

Also, could you send the patch as an attachment (your mail client munged
it somehow)?  You can create the patch by first committing locally and
then running (say) ‘git format-patch HEAD^’.

Bonus points if your commit log follows the GNU ChangeLog style:


You can imitate previous entries shown by ‘git log’.

(I think this patch is acceptable without copyright assignment.  Beyond
that, we’ll need copyright assignment, as discussed on IRC.)

Thanks in advance!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]