[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] distro: Add libtiff.

From: Ludovic Courtès
Subject: Re: [PATCH 2/2] distro: Add libtiff.
Date: Thu, 17 Jan 2013 23:39:25 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Andreas Enge <address@hidden> skribis:

> Two patches attached, since "make check" did not work for libtiff with 
> libjepg 9, so I also added libjpeg 8d.


> +(define-public libjpeg-8
> +  (package
> +   (name "libjpeg-8")
> +   (version "8d")

Please, move the definition after that of ‘libjpeg’, and write it like this:

  (define-public libjpeg-8
    (package (inherit libjpeg)
      (version "8d")
      (source (origin
               (method url-fetch)
               (uri (string-append "http://www.ijg.org/files/jpegsrc.v";
                      version ".tar.gz"))
               (sha256 (base32

This way, only the fields that differ need to be defined.

Other than that, go ahead.

Note that I’d like to rename (distro ...), and then tag the release, so
I will ask you not to commit after this one.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]