[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] utils: Add 'wrap-program'.

From: Ludovic Courtès
Subject: Re: [PATCH] utils: Add 'wrap-program'.
Date: Sun, 03 Mar 2013 22:29:39 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Nikita Karetnikov <address@hidden> skribis:

>> I wouldn’t bother, though, because it will be used in contexts where
>> there’s no risk of ‘prog’ being used while we’re fiddling with it
>> (single-threaded, after ‘make install’).
> Better safe than sorry.  So I added '.PROG-tmp'.

Good.  :-)

> +    (copy-file prog prog-real)

You lack a (chmod prog-real #o755), I think.

> +    (with-output-to-file prog-tmp
> +                         (lambda ()

Opening bracket aligned with the ‘i’, please.  :-)

Other than that it looks perfect, and ready to be pushed.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]