[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add cmake.

From: Cyril Roelandt
Subject: Re: [PATCH] gnu: Add cmake.
Date: Fri, 15 Mar 2013 03:12:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 03/14/2013 06:39 PM, Ludovic Courtès wrote:
Cyril Roelandt<address@hidden>  skribis:

* gnu/packages/cmake.scm: New file.
* gnu/packages/patches/cmake-fix-tests.patch: New file.
* Makefile.am: Add them.

Thanks!  Can you add a comment at the top of the patch saying what it
does, why, with a pointer to any relevant mailing list discussion or


Ideally all patches should eventually be submitted upstream, but
sometimes it’s not desirable, because the changes would too specific or
intrusive.  State it in the patch if that is the case.

Here, these tests require network connectivity, so I don't think upstream will accept the patches.

Other than that, looks good to me, so feel free to push then.

It would be great to have a ‘cmake-build-system’, which would be based
on ‘gnu-build-system’ but with specific ‘configure’ and ‘test’ phases.
See guix/build-system/perl.scm and related files for an example.  :-)

I'll have to try and package a piece of software requiring cmake, then :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]