[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Add (guix build-system cmake).

From: Ludovic Courtès
Subject: Re: [PATCH 1/2] Add (guix build-system cmake).
Date: Tue, 26 Mar 2013 23:09:10 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Cyril Roelandt <address@hidden> skribis:

> * guix/build/cmake-build-system.scm, guix/build-system/cmake.scm: New files.
> * Makefile.am (MODULES): Add them.

Overall looks good to me, nice!

> +;; Standard build procedure for packages using cmake. This is implemented as 
> an

Please spell it as “CMake”.  Also, two spaces after a period ending a

> +(define* (cmake-build store name source inputs

Admittedly these bits look like copy/pasting, but I’m not sure how to
factorize more.

> +                (description "The standard cmake build system")


> +;; XXX Parallel tests are disabled by default because I have no idea how they
> +;; work in cmake.

CMake generates a Makefile, so running ‘make -jX’ just works.  Thus you
can leave #:parallel-{build,tests}? to #t by default.

> +(define* (check #:key (tests? #t) (parallel-tests? #f) (test-target "test")
> +                #:allow-other-keys)
> +  (let ((gnucheck (assoc-ref gnu:%standard-phases 'check)))



Please push after fixing these.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]