bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25177: python-tests: python-oslosphinx fixed. Please evaluate.


From: Marius Bakke
Subject: bug#25177: python-tests: python-oslosphinx fixed. Please evaluate.
Date: Fri, 24 Feb 2017 23:20:58 +0100
User-agent: Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu)

Ricardo Wurmus <address@hidden> writes:

> Ricardo Wurmus <address@hidden> writes:
>
>> Leo Famulari <address@hidden> writes:
>>
>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>> From: Ricardo Wurmus <address@hidden>
>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>
>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>> tests.
>>>
>>> LGTM
>>
>> The problem was fixed in the upstream commit 93f984b in response to my
>> bug report:
>>
>>     
>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>
>> I believe we can just backport this fix instead of deleting the test.
>
> Here’s a patch that fixes the tests by applying the changes of the
> upstream commit.  If this is fine I’ll push it to the python-tests
> branch.

I tried this patch, and guess the reason it was not pushed is because
dendropy now has a different failure. Can you look into it?

Currently, I can build all of 'guix package -A python' on amd64, and
have fixed the few i686 problems on Hydra. Except for these three:

python-dendropy
python-openid
python-axolotl

Given that the two latter packages have security implications I would
rather leave them broken, than ignoring the test failures. They don't
have any in-tree users.

I don't always break packages wittingly, but when I do, it's on
'master'. Should we do a final Hydra round, or just merge it to the
master branch first? The 'python-tests' branch haven't been synced in a
while, so many substitutes will be out of date.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]