[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core m
From: |
Marius Bakke |
Subject: |
bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines. |
Date: |
Thu, 13 Apr 2017 21:38:46 +0200 |
User-agent: |
Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Hi, thanks for working on these!
[...]
> (define-public findutils
> (package
> - (name "findutils")
> - (version "4.6.0")
> - (source (origin
> - (method url-fetch)
> - (uri (string-append "mirror://gnu/findutils/findutils-"
> - version ".tar.gz"))
> - (sha256
> - (base32
> - "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> - (patches (search-patches "findutils-localstatedir.patch"
> - "findutils-test-xargs.patch"))))
> - (build-system gnu-build-system)
> - (arguments
> - `(#:configure-flags (list
> - ;; Tell 'updatedb' to write to /var.
> - "--localstatedir=/var"
> -
> - ;; Work around cross-compilation failure. See
> - ;; <http://savannah.gnu.org/bugs/?27299#comment1>.
> - ,@(if (%current-target-system)
> - '("gl_cv_func_wcwidth_works=yes")
> - '()))))
> - (synopsis "Operating on files matching given criteria")
> - (description
> - "Findutils supplies the basic file directory searching utilities of the
> + (name "findutils")
> + (version "4.6.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/findutils/findutils-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> + (patches (search-patches
> + "findutils-localstatedir.patch"
> + "findutils-test-xargs.patch"
> + ;; test-lock has performance issues on multi-core
> + ;; machines, it hangs or takes a long time to
> complete.
> + ;; This is a commit from gnulib to fix this issue.
> + "findutils-gnulib-multi-core.patch"))))
Please don't mix large indentation changes with functional changes. It
is really difficult to tell what this commit does. Can you split the
indentation change out in a separate commit?
signature.asc
Description: PGP signature
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, (continued)
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Mathieu Othacehe, 2017/04/12
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Ludovic Courtès, 2017/04/12
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Bruno Haible, 2017/04/12
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Ludovic Courtès, 2017/04/12
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Mathieu Othacehe, 2017/04/13
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Ludovic Courtès, 2017/04/13
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Mathieu Othacehe, 2017/04/13
- bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Ludovic Courtès, 2017/04/22
bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores, Ludovic Courtès, 2017/04/12
bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines., Mathieu Othacehe, 2017/04/13
- bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines.,
Marius Bakke <=
- bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines., Mathieu Othacehe, 2017/04/13
- bug#26441: [PATCH 1/2] gnu: findutils: Fix make check issues on multi-core machines., Mathieu Othacehe, 2017/04/13
- bug#26441: [PATCH 2/2] gnu: findutils: Reindent package definition., Mathieu Othacehe, 2017/04/13
- bug#26441: [PATCH 1/2] gnu: findutils: Fix make check issues on multi-core machines., Marius Bakke, 2017/04/15
- bug#26441: [PATCH 1/2] gnu: findutils: Fix make check issues on multi-core machines., Mathieu Othacehe, 2017/04/17
- bug#26441: [PATCH 1/2] gnu: findutils: Fix make check issues on multi-core machines., Marius Bakke, 2017/04/17
bug#26441: [PATCH 1/3] build: Add two missing patches to local.mk., Mathieu Othacehe, 2017/04/17