[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34407: [PATCH] shepherd: Delete the socket file upon exit.
From: |
宋文武 |
Subject: |
bug#34407: [PATCH] shepherd: Delete the socket file upon exit. |
Date: |
Sat, 23 Feb 2019 16:53:00 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Danny Milosavljevic <address@hidden> writes:
> On Sun, 17 Feb 2019 11:38:16 +0800
> address@hidden (宋文武) wrote:
>
>> Yes, I have the 'rm /run/user/1000/shepherd/socket' workaround in my session
>> script too...
>>
>> According to 'man 2 bind', the socket pathname should be deleted when no
>> longer required, so a patch to fix this bug:
>
> Hmm, I guess you can do that.
>
> But /run is supposed to be a tmpfs and elogind is supposed to rm -rf
> /run/user/1000
> after all sessions of that user terminated in any case, so how is it left over
> in the first place?
>
Well, maybe the elogind version I used didn't have this feature, or I
had another user session running...
> If the deletion in the case above doesn't work, please report a bug.
Thanks, good to know, and it indeed works.
>
> If that patch is only in order to enable users to restart user's shepherd
> without exiting all their sessions, then I guess that's ok--although unusual.
>
> Does your patch do the right thing if the user's shepherd is already
> running? (i.e. keep the socket file)
Yes, it deletes the socket file at exit (not at startup).