[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35941: Newt installer failure when wifi name is #f
From: |
Mathieu Othacehe |
Subject: |
bug#35941: Newt installer failure when wifi name is #f |
Date: |
Tue, 28 May 2019 11:17:31 +0200 |
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Hey Pierre,
You can find the backtrace in /tmp/last-installer-error file.
About the bug itself, it has been reported here:
https://issues.guix.gnu.org/issue/35622
Both patches seems fine to me, but I'd like to understand why the regex
fails. Could you run this command and report the result:
--8<---------------cut here---------------start------------->8---
for s in $(connmanctl services | cut -c 25- | grep wifi) ; do connmanctl
service $s ; done
--8<---------------cut here---------------end--------------->8---
Thanks,
Mathieu
> Apparently it fails because a wifi service name is #f.
>
> I can think of two fixes (untested). In wifi.scm:
>
> --8<---------------cut here---------------start------------->8---
> @@ -144,6 +144,7 @@ of <service-item> records present in LISTBOX."
> (let ((services (connman-services)))
> (filter (lambda (service)
> (and (string=? (service-type service) "wifi")
> + (service-name service)
> (not (string-null? (service-name service)))))
> services)))
> --8<---------------cut here---------------end--------------->8---
>
> Or, more directly in connman.scm:
>
> --8<---------------cut here---------------start------------->8---
> @@ -108,7 +108,8 @@
> (define-record-type* <service>
> service make-service
> service?
> - (name service-name) ; string
> + (name service-name
> + (default ""))
> (type service-type) ; string
> (path service-path) ; string
> (strength service-strength) ; integer
> --8<---------------cut here---------------end--------------->8---
>
> Thoughts?