[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs

From: Tobias Geerinckx-Rice
Subject: bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs
Date: Mon, 16 Sep 2019 12:26:46 +0200


Martin Becze 写道:
ping :P


The diff you sent here[0] is incomplete (it relies on your previous patch and doesn't have a header); please always send git-formatted patches that apply directly to current master. They are easier to merge and will be merged sooner.

Yeah I don't know. I just used prefix in the latest patch. Let me know
if the other method is preferred.


I've pushed this to master as ad6e168b3f29576d92b00725dedbb38cd5f05e46 with the following changes:

- Moved widowed ‘#:phases’ to the previous line (in well-formatted Scheme, ‘(’ can never end a line and ‘)’ should never start one), same for 'phase 'names - then decided to move ’#:phases’ below ‘#:configure-flags’. This is subjective, but since *flags ‘affect’ phases (never the other way 'round) it felt right :-)
- dropped the unused ‘inputs’ phase argument
- added the missing ":" separator to the prefix wrapping — if it does work without one (I didn't test), that's undocumented & shouldn't be relied upon
- removed unnecessary trailing / in ‘schemas/’
- and wrote a commit message as mostly documented in ‘info (standards)Change Logs’.



[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36896#53

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]