bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40613: [PATCH] gnu: Add emacs-typing.


From: Maxim Cournoyer
Subject: bug#40613: [PATCH] gnu: Add emacs-typing.
Date: Thu, 22 Oct 2020 17:33:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello Nicolas, Alberto,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-typing): New variable.
>
> Thank you.
>
>> +(define-public emacs-typing
>> +  (package
>> +    (name "emacs-typing")
>> +    (version "1.1.4")
>
> This is not a regular release, this is extracted from the main file. We
> need to provide a commit and a revision. See, e.g., "emacs-dhall-mode".
>
>> +    (description "@code{emacs-typing} is a game for Emacs that
>
> I would write "The Typing of Emacs" instead of emacs-typing, i.e., the
> name of the game instead of the symbol.
>
>> +forces you to type words correctly as fast as possible, otherwise
>> +you will die.  The game builds the list of words from the active buffer")
>
> The description is missing a final dot.
>
>> +    (license license:gpl2)))
>
> The license is gpl2+.
>
> Could you send an updated patch?

I modified the original definition with your above suggestions and
pushed as commit a49bfa1f6c22363c9e495070f51b82e60b1495af.

Closing.

Thank you!

Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]