bug#47018: core-updates: make check fails when guix-daemon is running

[Lars-Dominik Braun]

Hi Chris,

> Lars-Dominik, I'm CCing you on this email because you introduced the
> code discussed below, so I'm hoping you might know something about it.
> If you could please take a look, I'd really appreciate it!
I’m pretty sure it worked when I submitted the patch. Looking at the
untruncated backtrace and `git blame guix/packages.scm` I’d guess that the
recent changes to patch-and-repack somehow broke this. But that’s really all I
can say unfortunately. Maybe CC Maxim Cournoyer, who made that change
(cfcead2e515c0dae02127e5a76496463898be6b6)?

---snip---
Backtrace:
In guix/packages.scm:
  1522:22 19 (thunk)
  1451:25 18 (bag->derivation #<store-connection 256.99 7fa2f699daa0> #<<bag> 
name: "tzdata-2020d" system: "x86_64-linux" target: #f build-inputs: (("source" 
#<origin "https://data.iana.org/time-zones/releases/tzdata2020d.tar.gz"; 
#<content-hash sha256:1wxskk9mh1x2073n99qna2mq58mgi648mbq5dxlqfcrnvrbkk0cd> () 
7fa2f96e7360>) ("tzcode" #<origin 
"https://data.iana.org/time-zones/releases/tzcode2020d.tar.gz"; #<content-hash 
sha256:1mgsckixmmk9qxzsflfxnp3999qi3ls72bgksclk01g852x51w3c> () 7fa2fee73b40>) 
("tar" #<package tar@1.34 guix/build-system/gnu.scm:143 7fa2fee78a00>) ("gzip" 
#<package gzip@1.10 guix/build-system/gnu.scm:143 7fa2fee78820>) ("bzip2" 
#<package bzip2@1.0.8 guix/build-system/gnu.scm:143 7fa2fee78640>) ("xz" 
#<package xz@5.2.5 guix/build-system/gnu.scm:143 7fa2fee78460>) ("file" 
#<package file@5.39 guix/build-system/gnu.scm:143 7fa2fee78280>) ("diffutils" 
#<package diffutils@3.7 guix/build-system/gnu.scm:143 7fa2fee780a0>) ("patch" 
#<package patch@2.7.6 guix/build-system/g…> …)
In srfi/srfi-1.scm:
   586:29 17 (map1 (("source" #<origin 
"https://data.iana.org/time-zones/releases/tzdata2020d.tar.gz"; #<content-hash 
sha256:1wxskk9mh1x2073n99qna2mq58mgi648mbq5dxlqfcrnvrbkk0cd> () 7fa2f96e7360>) 
("tzcode" #<origin 
"https://data.iana.org/time-zones/releases/tzcode2020d.tar.gz"; #<content-hash 
sha256:1mgsckixmmk9qxzsflfxnp3999qi3ls72bgksclk01g852x51w3c> () 7fa2fee73b40>) 
("tar" #<package tar@1.34 guix/build-system/gnu.scm:143 7fa2fee78a00>) ("gzip" 
#<package gzip@1.10 guix/build-system/gnu.scm:143 7fa2fee78820>) ("bzip2" 
#<package bzip2@1.0.8 guix/build-system/gnu.scm:143 7fa2fee78640>) ("xz" 
#<package xz@5.2.5 guix/build-system/gnu.scm:143 7fa2fee78460>) ("file" 
#<package file@5.39 guix/build-system/gnu.scm:143 7fa2fee78280>) ("diffutils" 
#<package diffutils@3.7 guix/build-system/gnu.scm:143 7fa2fee780a0>) ("patch" 
#<package patch@2.7.6 guix/build-system/gnu.scm:143 7fa2fee7ae60>) ("findutils" 
#<package findutils@4.8.0 guix/build-system/gnu.scm:143 7fa2fee7ac80>) ("gawk" 
#<pack…>) …))
   586:29 16 (map1 (("tzcode" #<origin 
"https://data.iana.org/time-zones/releases/tzcode2020d.tar.gz"; #<content-hash 
sha256:1mgsckixmmk9qxzsflfxnp3999qi3ls72bgksclk01g852x51w3c> () 7fa2fee73b40>) 
("tar" #<package tar@1.34 guix/build-system/gnu.scm:143 7fa2fee78a00>) ("gzip" 
#<package gzip@1.10 guix/build-system/gnu.scm:143 7fa2fee78820>) ("bzip2" 
#<package bzip2@1.0.8 guix/build-system/gnu.scm:143 7fa2fee78640>) ("xz" 
#<package xz@5.2.5 guix/build-system/gnu.scm:143 7fa2fee78460>) ("file" 
#<package file@5.39 guix/build-system/gnu.scm:143 7fa2fee78280>) ("diffutils" 
#<package diffutils@3.7 guix/build-system/gnu.scm:143 7fa2fee780a0>) ("patch" 
#<package patch@2.7.6 guix/build-system/gnu.scm:143 7fa2fee7ae60>) ("findutils" 
#<package findutils@4.8.0 guix/build-system/gnu.scm:143 7fa2fee7ac80>) ("gawk" 
#<package gawk@5.1.0 guix/build-system/gnu.scm:143 7fa2fee7aaa0>) ("sed" 
#<package sed@4.8 gnu/packages/commencement.scm:3648 7fa2fee78be0>) ("grep" 
#<package grep@3.6 gnu/packages/c…>) …))
   586:17 15 (map1 (("tar" #<package tar@1.34 guix/build-system/gnu.scm:143 
7fa2fee78a00>) ("gzip" #<package gzip@1.10 guix/build-system/gnu.scm:143 
7fa2fee78820>) ("bzip2" #<package bzip2@1.0.8 guix/build-system/gnu.scm:143 
7fa2fee78640>) ("xz" #<package xz@5.2.5 guix/build-system/gnu.scm:143 
7fa2fee78460>) ("file" #<package file@5.39 guix/build-system/gnu.scm:143 
7fa2fee78280>) ("diffutils" #<package diffutils@3.7 
guix/build-system/gnu.scm:143 7fa2fee780a0>) ("patch" #<package patch@2.7.6 
guix/build-system/gnu.scm:143 7fa2fee7ae60>) ("findutils" #<package 
findutils@4.8.0 guix/build-system/gnu.scm:143 7fa2fee7ac80>) ("gawk" #<package 
gawk@5.1.0 guix/build-system/gnu.scm:143 7fa2fee7aaa0>) ("sed" #<package 
sed@4.8 gnu/packages/commencement.scm:3648 7fa2fee78be0>) ("grep" #<package 
grep@3.6 gnu/packages/commencement.scm:3632 7fa2fee78e60>) ("coreutils" 
#<package coreutils@8.32 guix/build-system/gnu.scm:143 7fa2fee74140>) ("make" 
#<package make@4.3 gnu/packages/commencement.scm:…>) …))
In guix/packages.scm:
  1227:16 14 (expand-input #<store-connection 256.99 7fa2f699daa0> #<package 
tzdata@2020d guix/packages.scm:448 7fa2f7ccc5a0> ("tar" #<package tar@1.34 
guix/build-system/gnu.scm:143 7fa2fee78a00>) "x86_64-linux" _)
  1184:16 13 (package-derivation _ #<package tar@1.34 
guix/build-system/gnu.scm:143 7fa2fee78a00> _ #:graft? _)
  1522:22 12 (thunk)
  1451:25 11 (bag->derivation #<store-connection 256.99 7fa2f699daa0> #<<bag> 
name: "tar-1.34" system: "x86_64-linux" target: #f build-inputs: (("source" 
#<origin "mirror://gnu/tar/tar-1.34.tar.xz" #<content-hash 
sha256:0a0x87anh9chbi2cgcyy7pmnm5hzk4yd1w2j8gm1wplwhwkbvgk3> 
("…/gnu/packages/patches/tar-skip-unreliable-tests.patch" 
"…/gnu/packages/patches/tar-remove-wholesparse-check.patch") 7fa2f7b41360>) 
("coreutils" #<package coreutils@8.32 guix/build-system/gnu.scm:143 
7fa2fee74140>) ("grep" #<package grep@3.6 gnu/packages/commencement.scm:3632 
7fa2fee78e60>) ("locales" #<package glibc-utf8-locales@2.32 
gnu/packages/commencement.scm:3573 7fa2fee74640>) ("bash" #<package 
bash-minimal@5.0.16 gnu/packages/commencement.scm:3541 7fa2fee74960>) ("gcc" 
#<package gcc@7.5.0 gnu/packages/commencement.scm:3453 7fa2fee74aa0>) 
("ld-wrapper" #<package ld-wrapper-boot3@0 gnu/packages/base.scm:606 
7fa2f68acc80>) (…> …)
In srfi/srfi-1.scm:
   586:17 10 (map1 (("source" #<origin "mirror://gnu/tar/tar-1.34.tar.xz" 
#<content-hash sha256:0a0x87anh9chbi2cgcyy7pmnm5hzk4yd1w2j8gm1wplwhwkbvgk3> 
("…/gnu/packages/patches/tar-skip-unreliable-tests.patch" 
"…/gnu/packages/patches/tar-remove-wholesparse-check.patch") 7fa2f7b41360>) 
("coreutils" #<package coreutils@8.32 guix/build-system/gnu.scm:143 
7fa2fee74140>) ("grep" #<package grep@3.6 gnu/packages/commencement.scm:3632 
7fa2fee78e60>) ("locales" #<package glibc-utf8-locales@2.32 
gnu/packages/commencement.scm:3573 7fa2fee74640>) ("bash" #<package 
bash-minimal@5.0.16 gnu/packages/commencement.scm:3541 7fa2fee74960>) ("gcc" 
#<package gcc@7.5.0 gnu/packages/commencement.scm:3453 7fa2fee74aa0>) 
("ld-wrapper" #<package ld-wrapper-boot3@0 gnu/packages/base.scm:606 
7fa2f68acc80>) ("libc" #<package glibc@2.32 gnu/packages/commencement.scm:3348 
7fa2fee74dc0>) ("libc:static" #<package glibc@2.32 gnu/p…> …) …))
In guix/packages.scm:
   1246:5  9 (expand-input _ _ _ _ _)
In ice-9/boot-9.scm:
  1736:10  8 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In guix/packages.scm:
  1251:18  7 (_)
In guix/store.scm:
  2066:24  6 (run-with-store #<store-connection 256.99 7fa2f699daa0> 
#<procedure 7fa2f69c6540 at guix/gexp.scm:246:2 (state)> #:guile-for-build _ 
#:system _ #:target _)
   1900:8  5 (_ _)
In guix/gexp.scm:
   256:18  4 (_ _)
In guix/packages.scm:
   1638:7  3 (_ _)
    619:2  2 (patch-and-repack #<derivation 
/gnu/store/l9nzv7lmznp2y22i2n3j7mccz5jjhlv1-tar-1.34.tar.xz.drv => 
/gnu/store/4y8yhyxhvh725bp3bk7wzr3jn8r5hjm0-tar-1.34.tar.xz 7fa2f699d280> 
("…/gnu/packages/patches/tar-skip-unreliable-tests.patch" 
"…/gnu/packages/patches/tar-remove-wholesparse-check.patch") #:inputs _ 
#:snippet _ #:flags _ #:modules _ #:guile-for-build _ #:system _)
In unknown file:
           1 (string-drop 
"/gnu/store/4y8yhyxhvh725bp3bk7wzr3jn8r5hjm0-tar-1.34.tar.xz" 91)
In ice-9/boot-9.scm:
  1669:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1669:16: In procedure raise-exception:
Value out of range 0 to 59: 91
---snap---

Cheers,
Lars