bug#33609: fortune-mod build (test) failure

[Sarah Morgensen]

Hi,

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
> valgrind test.  This is not ideal but better than having a broken
> package.
>
> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
> could be related.

This seems to be fixed now.  I've attached a patch below to reenable it.

It could probably do with an update, too.  It now vendors 'rinutils'
(which we already have as an input) so that would need to be removed.

--
Sarah

>From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001
Message-Id: 
<5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskarian@mgsn.dev>
From: Sarah Morgensen <iskarian@mgsn.dev>
Date: Mon, 13 Sep 2021 21:40:43 -0700
Subject: [PATCH] gnu: fortune-mod: Re-enable test.

Re-enable the valgrind test, fixed in a previous version update.

* gnu/packages/games.scm (fortune-mod)[arguments]<#:phases>
{fix-build-env}: Re-enable test.
---
 gnu/packages/games.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a2f756e3a7..4236560143 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7633,11 +7633,7 @@ original.")
                (copy-file cmake-rules
                           (string-append "fortune-mod/cmake/"
                                          (strip-store-file-name cmake-rules)))
-               (chdir "fortune-mod")
-               ;; TODO: Valgrind tests fail for some reason.
-               ;; Similar issue: 
https://github.com/shlomif/fortune-mod/issues/21 (?)
-               (delete-file "tests/t/valgrind.t")
-               #t)))
+               (chdir "fortune-mod"))))
          (add-after 'install 'fix-install-directory
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Move binary from "games/" to "bin/" and remove the latter.  
This

base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1
-- 
2.33.0