bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50595: Faliure in guix import go


From: Ludovic Courtès
Subject: bug#50595: Faliure in guix import go
Date: Sat, 18 Sep 2021 23:12:41 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hi,

Sarah Morgensen <iskarian@mgsn.dev> skribis:

>>From b9ef64a641c20d331cf1886d71b85b81be910b30 Mon Sep 17 00:00:00 2001
> Message-Id: 
> <b9ef64a641c20d331cf1886d71b85b81be910b30.1631914185.git.iskarian@mgsn.dev>
> From: Sarah Morgensen <iskarian@mgsn.dev>
> Date: Thu, 16 Sep 2021 18:24:40 -0700
> Subject: [PATCH] import: go: Improve handling of modules in VCS
>  subdirectories.
>
> Use the supplied module path (instead of the repository root) as the import
> path for everything except source and homepage URLs.  For modules not in the
> root of a VCS repository, set #:unpack-path to the repository root by default.
>
> * guix/import/go.scm (go-module->guix-package): Use 'module-path'
> instead of 'root-module-path' for #:import-path.  Emit #:unpack-path
> when #:import-path is not equal to 'root-module-path'.

[...]

>>From ca17299a3011171d6889202003d1e888b22303ec Mon Sep 17 00:00:00 2001
> Message-Id: 
> <ca17299a3011171d6889202003d1e888b22303ec.1631842353.git.iskarian@mgsn.dev>
> From: Sarah Morgensen <iskarian@mgsn.dev>
> Date: Thu, 16 Sep 2021 18:27:09 -0700
> Subject: [PATCH] import: go: Match "go-import" meta tags anywhere.
>
> Some personal sites forget to put <meta name="go-import" ...> in a
> <head> element, so look anywhere for them.
>
> * guix/import/go.scm (fetch-module-meta-data): Match "go-import" meta
> tags anywhere in the page.

I went ahead and pushed these two patches on your behalf (after adding a
reference to this bug):

  281ede2e7d * import: go: Match "go-import" meta tags anywhere.
  b3907e304d * import: go: Improve handling of modules in VCS subdirectories.

Should we close this bug now, Sarah?

Thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]