[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50896: emacs-beancount broken, moved to its own project
From: |
Nicolas Goaziou |
Subject: |
bug#50896: emacs-beancount broken, moved to its own project |
Date: |
Wed, 29 Sep 2021 21:30:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Christine Lemmer-Webber <cwebber@dustycloud.org> writes:
> + (let ((commit "dbafe6a73d90c1f64d457b356b9dbb43499f70d5")
> + (revision "0"))
I suggest to mention in a comment that upstream has not made any release
yet.
> + (package
> + (name "emacs-beancount")
> + (version (git-version "0.0.0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/beancount/beancount-mode")
> + (commit commit)))
> + (sha256
> + (base32
> + "0v9bws2gv5b00x829p7hrcxqgdp7iwxvv1vhfjka81qrw6w1fvjw"))
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (license license:gpl3+)
Nitpick: usually, license field is at the end of the package definition.
> + (home-page "https://github.com/beancount/beancount-mode")
> + (inputs '())
> + (native-inputs '())
You can remove inputs and native-inputs fields, since they are empty.
> + (synopsis "Emacs mode for beancount")
Nitpick: beancount -> Beancount
> + (description
> + "Emacs-beancount is an Emacs mode for the Beancount accounting
> tool."))))
Otherwise, LGTM!
Regards,
--
Nicolas Goaziou