bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40641: Building from git breaks when /bin/sh isn't bash


From: elaexuotee
Subject: bug#40641: Building from git breaks when /bin/sh isn't bash
Date: Tue, 19 Jul 2022 13:14:03 +0900
User-agent: mblaze/1.2

Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> I'll see if these Bashisms can be easily switched to POSIX variants,
> else I'll experiment with setting the shebang of the test scripts to
> bash.

Is there any particular reason to go this route?

Writing portable scripts is full of all sorts of pitfalls and ill-meaning
dragons:

- What if SHELL=tcsh?
- What about incompatible behaviour between bash versions?
- Do we want to write tests to future-proof fixes for the above?

In this case, since the build is running inside a guix shell, I don't really
see any reason to *not* effectively pin the scripts to use the bash available
in that environment.

Am I missing something?

Cheers,
B





reply via email to

[Prev in Thread] Current Thread [Next in Thread]