[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] gzip: add "--keep" option to keep (don't delete) input fi

From: Rodrigo Campos
Subject: Re: [PATCH v3] gzip: add "--keep" option to keep (don't delete) input files
Date: Wed, 13 Feb 2013 14:24:45 -0300
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Feb 13, 2013 at 06:07:59PM +0100, Antonio Diaz Diaz wrote:
> Rodrigo Campos wrote:
> >Not sure I follow you. If "--stdout" is used, keep is set to true (or to 1 
> >:))
> Yes, but using --stdout is not the only way of setting to_stdout to
> true. --list, for example, sets to_stdout to true but does not set
> keep.
> Then you made the change
> -    if (!to_stdout)
> +    if (!keep)
> removing to_stdout from the condition. So I guess "gzip --list file"
> will now delete "file".

Ohh, sorry, I didn't understand before. Well, it does not delete "file" now
(I've just tried), it seems that function is not called.

But it seems better to keep them separated, I'll send a new patch with this :-D

Thanks a lot for the review,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]