[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#22768: Crash safety

From: Paul Eggert
Subject: bug#22768: Crash safety
Date: Sun, 28 Feb 2016 00:26:58 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

Antonio Diaz Diaz wrote:

ddrescue already provides the option '-y, --synchronous' for a somewhat
similar functionality.

OK, let's do it as --synchronous, long-only. If the need keeps growing we can add -y.

Just now my preference is to make the behavior optional

On second thought, as Bob Proulx suggested, this is a better approach. I tried the a synchronous gzip on a contrived example (compressing 1000 empty files on an ext4 file system on an actual hard drive with options relatime, seclabel, data=ordered) and synchronizing made gzip 700x slower. Most people will prefer the old behavior, where gzip is faster and is unsafe mostly just in theory.

I'm attaching the patches I installed recently in this area, to help fix this problem. I'll follow up on your other recent email in another message soon.

Attachment: 0001-gzip-fdatasync-output-dir-before-unlinking.patch
Description: Text Data

Attachment: 0002-gzip-use-constants-not-fileno.patch
Description: Text Data

Attachment: 0003-gzip-new-option-synchronous.patch
Description: Text Data

Attachment: 0004-misc-update-version-copyright.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]