[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24826: [PATCH 1/2] gzip --no-name: avoid spurious warning

From: Paul Eggert
Subject: bug#24826: [PATCH 1/2] gzip --no-name: avoid spurious warning
Date: Fri, 4 Nov 2016 20:36:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

Jim Meyering wrote:
The first one is a clear bug fix.

Oops, my bad. Thanks for catching that. I installed a simpler fix (first attached patch).

For the second, since --no-time (-T) never worked (-m does),
I could also just remove its entry from longopts. We've
done without it for so long, there's little point to adding
an undocumented --no-time, now.

Thanks, I like that idea and installed the 2nd attached patch.

In rereading the code I noticed other problems likely to bite after the year 2038 (3rd attached patch, also installed). This stuff is a pain, as it won't see realistic testing for another 20 years or so and I don't see easy test cases for it, partly because GNU/Linux seems to mishandles these time stamps now on my platform (Fedora 24 x86-64; I'll try to file a bug report about this to Fedora).

Boldly marking the bug as done.

Attachment: 0001-gzip-no-name-avoid-spurious-warning.patch
Description: Text Data

Attachment: 0002-gzip-no-time-cleanup.patch
Description: Text Data

Attachment: 0003-gzip-minor-time-stamp-cleanups.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]