[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32375: Bug Gzip v1.9
From: |
Johannes Przybilla |
Subject: |
bug#32375: Bug Gzip v1.9 |
Date: |
Sun, 19 Aug 2018 12:34:22 +0200 |
Hello Paul.
I only recently got around to check the fix you committed.
It seems to me that after 'volatile_strcpy (remove_ofname, ofname);‘ the
'remove_ofname‘ variable is not used anymore.
The 'xunlink' function in 'remove_output_file' is still called on 'ofname'
instead of 'remove_ofname‘.
Therefore the non-volatile access still occurs in the signal handler.
Could you look into that?
Best regards,
Johannes
> Am 08.08.2018 um 11:34 schrieb Paul Eggert <address@hidden>:
>
> Johannes Przybilla wrote:
>> This can lead to undefined behaviour for example in the case of nested
>> signal handler calls
>
> These can't happen in gzip, so we should be OK here.