bug-hello
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix new format when printing multiple lines


From: Sami Kerola
Subject: Re: [PATCH] fix new format when printing multiple lines
Date: Tue, 10 Dec 2013 18:53:45 +0000

On 4 December 2013 22:41, Sami Kerola <address@hidden> wrote:
> On 4 December 2013 22:25, Reuben Thomas <address@hidden> wrote:
>> On 4 December 2013 22:02, Sami Kerola <address@hidden> wrote:
>>>
>>> * Makefile.am: add test
>>> * src/hello.c: add new function print_box()
>>> * tests/multiline-box-1: test multiline printing
>>
>> Looks good.
>
> I'll wait couple days before pushing this change. One of the things
> that should be added to manual page is a bug. In case tab width is not
> 8 character --next-generation --greeting that has tabs may result with
> broken output. Rather than fixing the bug it is probably better to
> demonstrate how to add extra info to help2man output.

The new format + multi line greeting fix is pushed.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]