[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: memory leak in pflocal

From: Roland McGrath
Subject: Re: memory leak in pflocal
Date: Sat, 10 Feb 2001 20:31:21 -0500 (EST)

That looks correct to me, but you should do connect_queue as well.  You
should be guaranteed that the queues are empty (length 0) by the time you
get there (because anyone on the queue would hold a ref to the sock).  But
it wouldn't hurt to have an assert in connq_destroy.  (cq->queue might
still need to be freed, because the ways things are written it is the
result of malloc(0) and it always might change whether that returns null or
allocates a tiny amount, best not to presume malloc(0)==0.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]