[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mach_host_self() doesn't acquire new port name?!

From: Roland McGrath
Subject: Re: mach_host_self() doesn't acquire new port name?!
Date: Sun, 6 May 2001 22:04:12 -0400 (EDT)

> Now, we actually leak all these urefs (for example, when calling
> gettimeofday). Even for a process calling mach_host_self() 1000 times a
> second it would take 50 days to overflow. For purity, should we deallocate
> the port? Overflow is set to TRUE in this code path, so it might
> be okay to just not bother anyway (ignoring that we might not want to bother
> because it is extremely unlikely to ever overflow)? Am I just paranoid?
> There are only a dozen places or so where we call mach_host_self, so it
> wouldn't be too hard to fix if that's the right thing to do.

Yes, that's appropriate.  It's probably just been omitted out of habit
because of the similarity to mach_task_self, which is a macro that doesn't
in fact add another uref.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]