[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hurd/term users.c
From: |
Roland McGrath |
Subject: |
Re: hurd/term users.c |
Date: |
Sun, 27 May 2001 15:57:17 -0400 (EDT) |
> > Log message:
> > 2001-05-26 Roland McGrath <roland@frob.com>
> >
> > * users.c (trivfs_S_io_select): Don't diagnose an error for *TYPE
> > containing irrelevant bits (i.e. SELECT_URG). It's always ok to
> > ask even when the answer is always no.
>
> I haven't looked at this change in detail, but I am concerned.
>
> The comment in the ChangeLog is not correct. For example, it is error
> to ask for SELECT_READ if the file is not open for reading.
Why do you say that? I have never known of such behavior. Linux does not
do it. FreeBSD does not do it. Those are the systems that it's handy for
me to check right now, but I don't know of any reason to ever have
suspected such a behavior. There is nowadays some standard that specifies
select, though I only have 1003.1-1996 (which does not). I would be
surprised if it required, or even allowed, such an error diagnosis
given the state of extant systems.
- Re: hurd/term users.c,
Roland McGrath <=