[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `daemons/rc.sh' and `daemons/runsystem.sh' depending on Bash

From: Roland McGrath
Subject: Re: [PATCH] `daemons/rc.sh' and `daemons/runsystem.sh' depending on Bash.
Date: Wed, 26 Dec 2001 16:40:55 -0500 (EST)

> The reason for making them POSIX shell compliant was because they were
> supposedly POSIX shell compatible in the beginning (or maybe that was
> Bourne shell compatible?).

I don't follow the logic or see the goal.  Depending on bash is not a
problem for the GNU system.

> The function `remove_translator' has be removed and replaced with a single
> command that is a lot cleaner.

Your change has the wrong semantics because find will call stat and
activate translators.  If you don't understand how remove_translator works
differently than your find command, please read up on translators.

> The change from `[' to `test' was mostly made so that the scripts are
> consistent with each other.

When presuming modern shells (which we are, i.e. at least POSIX), both of
these always work fine.  There is no substantive reason to prefer one over
the other, but most people go with [ ... ].  If we were to change it, I'd
rather change them all to [ ... ].  But I see no reason to bother changing
anything now.  The existing code works fine and is easy enough to read.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]