[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Sat, 11 May 2002 21:01:06 +0200
On Sat, Nov 17, 2001 at 12:15:00AM +0100, Neal H Walfield wrote:
> > Those void functions you changed to error_t can never fail, so I don't see
> > the point. The actual diskfs_make_node changes seem ok.
> They can never fail today, however, I thought it made the interface a
> bit more consistent. I guess, however, you are right, there is no
> Here is revised patch:
> 2001-11-16 Neal H Walfield <email@example.com>
> * diskfs.h (diskfs_make_node): Change the prototype. The node
> is now returned in a local argument and the function itself
> returns an error_t.
> * node-make.c (diskfs_make_node): Up date to new semantics.
> Do more through error checking.
You are leaking the DN disknode in the ext2fs and ufs case, please free(dn)
it. Also, please change the doc/hurd.texi (I know it's only patchwork, but
there is no reason to let it get out of sync even more if it is easy to
fix). With those changes, I think you can check it in.
`Rhubarb is no Egyptian god.' Debian http://www.debian.org firstname.lastname@example.org
Marcus Brinkmann GNU http://www.gnu.org email@example.com
|[Prev in Thread]
||[Next in Thread]|
- Re: diskfs_make_node,
Marcus Brinkmann <=