[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recent commits.

From: James Morrison
Subject: Re: Recent commits.
Date: Thu, 13 Jun 2002 19:41:34 -0700 (PDT)

 Looking at recent commits, I found this one:  (I know it has been mentioned)

2002-06-02  Roland McGrath  <roland@frob.com>

        * oskit/ds_routines.c (DEV_PTR_HASH): unsigned int -> uintptr_t
        (ds_device_write): unsigned int -> mach_msg_number_t

I don't believe changing COUNT from a unsigned int to mach_msg_number_t is
useful at all.  First mach_msg_number_t doesn't exist.  If it did exist
it seems it would be describing the variable, which calling the variable COUNT
already does.  So here is what I did.

Index: ds_routines.c
RCS file: /cvsroot/hurd/gnumach/oskit/ds_routines.c,v
retrieving revision 1.4
diff -u -r1.4 ds_routines.c
--- ds_routines.c       2 Jun 2002 23:19:37 -0000       1.4
+++ ds_routines.c       14 Jun 2002 02:35:47 -0000
@@ -692,7 +692,7 @@
 ds_device_write (device_t dev, ipc_port_t reply_port,
                 mach_msg_type_name_t reply_port_type, dev_mode_t mode,
-                recnum_t recnum, io_buf_ptr_t data, mach_msg_number_t count,
+                recnum_t recnum, io_buf_ptr_t data, unsigned int count,
                 int *bytes_written)
   if (dev == DEVICE_NULL)

James Morrison
   University of Waterloo
   Computer Science - Digital Hardware
   2A co-op

Anyone referring to this as 'Open Source' shall be eaten by a GNU

Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]