[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VT switching code in pc_kbd broken.

From: Marcus Brinkmann
Subject: Re: VT switching code in pc_kbd broken.
Date: Fri, 22 Nov 2002 01:09:57 +0100
User-agent: Mutt/1.4i

On Thu, Nov 21, 2002 at 09:48:38PM +0100, M. Gerards wrote:
> Because of recent changes in the pc_kbd code VC switching is broken (switching
> to VCs >2 doesn't work anymore). This was caused because the code assumes 
> things
> about the order of the scancodes of the function keys. Because isn't true for
> set 2 VC switching is broken.

I have put in a minimally different patch.  Two things you really
need to be careful about:

1. Your changelog didn't mention the other two macros you defined.  Just
because on macro is the helper of another one doesn't mean you can omit it. 
Instead adding them to the changelog, I just removed the macros as they were
useless anyway.

2. Your patch is not functionally equivalent.  You also allow switching to
F11 and F12.  You must document those functional differences, slipping in
such changes without notice is not acceptable.  Luckily I catched this and I
added a note to the changelog.

Thanks a lot for trying out the changes, and sending in the fix!


`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    marcus@gnu.org
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]