Re: Ping on a small patch...

[Marco Gerards]

"Alfred M. Szmidt" <ams@kemisten.nu> writes:

Hi,

> sometime ago (Apr 26) I sent an patch that fixes two compiler errors
> (conflicting types) in the current CVS tree.  Anyone wants to apply
> it?

Errors or warnings? I compiled the Hurd from CVS without problems a
week ago... How is this problem triggered? (using which gcc version,
etc.).

> --- term/term.h 26 Jun 2002 19:22:58 -0000      1.53
> +++ term/term.h 26 Apr 2003 13:17:51 -0000
> @@ -329,7 +329,7 @@
>  void init_users (void);
> 
>  extern char *tty_arg;
> -extern int rdev;
> +extern dev_t rdev;

This is correct. It was defined as a dev_t in main.c too.

> RCS file: /cvsroot/hurd/hurd/ufs-fsck/main.c,v
> retrieving revision 1.15
> diff -u -r1.15 main.c
> --- ufs-fsck/main.c     20 Feb 1997 04:17:39 -0000      1.15
> +++ ufs-fsck/main.c     26 Apr 2003 13:17:51 -0000
> @@ -34,7 +34,7 @@
>  int preen = 0;
> 
>  /* Total number of files found on the partition.  */
> -long num_files = 0;
> +daddr_t num_files = 0;

Same problem here. num_files was defined as daddr_t in fsck.h and
redefined as an int.

So I'm not sure if it solves problems (hopefully Alfred can explain
this), but it fixes some mistakes.

Thanks,
Marco