bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bugs in idvec-verify.c, almost...


From: Roland McGrath
Subject: Re: bugs in idvec-verify.c, almost...
Date: Sat, 6 Sep 2003 15:40:34 -0400 (EDT)

> >  if (getpwuid_r (id, &_pw, id_lookup_buf, sizeof id_lookup_buf, &pw)
> >      == 0)
> 
> That code is ugly anyway, we should do function calls outside of if
> conditions.  So this could be cleaned up along with the semantic fix.

There is nothing wrong with this kind of conditional.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]