[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for setting the keyboard LEDs state

From: Marcus Brinkmann
Subject: Re: Patch for setting the keyboard LEDs state
Date: Thu, 29 Jan 2004 09:22:50 +0100
User-agent: Mutt/1.5.4i

On Thu, Jan 29, 2004 at 02:09:46AM +0100, Marco Gerards wrote:
> Hi,
> I put a patch (#2543) on savannah to change the keyboard LEDs state in
> GNUMach.  This can be used with device_set_status.  I've also put a
> patch on savannah so the keyboard driver (pc_kbd) of the Hurd console
> can use this.

Please put all variables (data_cnt, led) into the else{} block.  You then
need to copy the led variable into the if{} block.  Even though their values
seem to agree by chance, let's not rely on this, just duplicate it so that
GNU Mach 1 and 2 are two independent chunks of code.  This makes it easier
to see what is going on.

Also put the code to change the LED for GNUMach into an #ifdef KDSETLEDS,
so that compiles with old headers don't fail.

Second, you have your keyboard fix in this patch, so take care not to check
it in accidentially.

Third, in your acupdate diff I spotted:

Watch out for such stuff.  I always go over the diff before posting it
somewhere for spurious changes like this.

If you have done the above, you can check in the LED patches.


`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    marcus@gnu.org
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]