[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c

From: Alfred M. Szmidt
Subject: Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c
Date: Tue, 2 Mar 2004 20:38:42 +0100 (MET)

   Debian Bug #190732 can be safely closed.  The patch you're talking
   about is in http://sv.gnu.org/patch/?func=detailitem&item_id=1839


   > What bug did this patch fix exactly?  Do you have any test cases
   > for this?

   Many small bugs are fixed.  Most of the sentences in the changelog
   entry are separate fixes that are not related to the other
   changelog entries.  If it's needed, I can make more detailed
   explanation about each sentence.

If you could, please do since it would be nice to get this into the
tree if it fixes bugs.

   > And for the future, please please please refrain from
   > obfuscuating the patch with cosmetic changes (like removing
   > redundat variables and what not).  It makes it so much harder to
   > read and follow.

   My observation is that such cosmetic changes (like changing
   comments and memset/memcpy) are rejected by Hurd core developers
   when they are alone, so the only way to commit them is to merge
   them with more essential patch.

I don't think they will reject them if they are sane and actually
clean up the code.  And if that doesn't work, just point to some
change by the gods that actually did a clean up. :)

Anyway, I find it more important to get actual fixes in, and a patch
that one can read without some unneeded cruft is really helpful.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]