[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warnings removed from linux/dev/drivers/block/genhd.c

From: Marcus Brinkmann
Subject: Re: Warnings removed from linux/dev/drivers/block/genhd.c
Date: Mon, 30 Jan 2006 20:27:33 -0500

On Tue, 2006-01-31 at 01:55 +0100, Alfred M. Szmidt wrote:
>    >    Are you sure that changing the #ifdef to #if is the right
>    >    change?
>    > 
>    > Quite, if you have specific concerns that I might have missed
>    > then please speak up.
>    Your patch is potentially a functional change; not simply a bug fix.
>    You've defended the addition of CONFIG_BSD_DISKLABEL but not the
>    change from #ifdef to #if.
> If you have specific concerns around it, please state them.  You have
> not done so.

He has stated his concern.  The patch contains a gratuitous change which
is not explained.  This is sufficient reason for us to not consider the


reply via email to

[Prev in Thread] Current Thread [Next in Thread]