bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Savannah task 5878 - port user_gdt


From: Barry deFreese
Subject: Re: Savannah task 5878 - port user_gdt
Date: Sat, 4 Nov 2006 21:21:30 -0500

----- Original Message ----- From: "Samuel Thibault" <samuel.thibault@ens-lyon.org>
To: "Barry deFreese" <bddebian@comcast.net>
Cc: <bug-hurd@gnu.org>
Sent: Saturday, November 04, 2006 8:40 PM
Subject: Re: Savannah task 5878 - port user_gdt


Hi,

Barry deFreese, le Sat 04 Nov 2006 20:14:08 -0500, a écrit :
I have an improved patch that does work and has been moderately
tested.

--- ChangeLog 4 Nov 2006 23:32:21 -0000 1.128.2.159
+++ ChangeLog 5 Nov 2006 01:04:41 -0000
@@ -1,3 +1,15 @@
+        * i386/i386/gdt.h (USER_GDT, USER_GDT_SLOTS): New macros.

You should also note that GDTSZ got modified too.

+ * i386/i386/thread.h (struct i386_machine_state): New member user_gdt.

And that gdt.h is included.

+        * Thanks to Samuel Thibault for fix ups and testing!

Not needed :)

--- i386/i386/gdt.h 4 Nov 2006 23:32:21 -0000 1.2.2.1
+++ i386/i386/gdt.h 5 Nov 2006 01:05:01 -0000
@@ -49,8 +49,9 @@
#define USER_FPREGS 0x40 /* user-mode access to saved
    floating-point registers */

-#define GDTSZ 11
-
+#define GDTSZ 13
+#define USER_GDT 0x48
+#define USER_GDT_SLOTS 2

You should define GDTSZ after USER_GDT and USER_GDT_SLOTS, and GDTSZ
should then rather be (USER_GDT/8 + USER_GDT_SLOTS)

Index: linux/src/include/linux/head.h
===================================================================
RCS file: /cvsroot/hurd/gnumach/linux/src/include/linux/Attic/head.h,v
retrieving revision 1.1
diff -u -r1.1 head.h
--- linux/src/include/linux/head.h 26 Apr 1999 05:56:28 -0000 1.1
+++ linux/src/include/linux/head.h 5 Nov 2006 01:05:03 -0000
@@ -5,7 +5,10 @@
 unsigned long a,b;
} desc_table[256];

-extern desc_table idt,gdt;
+/* XXX Linux code doesn't use idt/gdt? */
+/*
+ * extern desc_table idt,gdt;
+ */

They shouldn't ever use idt/gdt directly.

Samuel


Samuel,

Thanks for the feedback.  How's this one?

Barry

Attachment: gnumach_i386_gdt_2.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]