[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Support for alignment in the zone allocator

From: olafBuddenhagen
Subject: Re: [PATCH] Support for alignment in the zone allocator
Date: Thu, 4 Jan 2007 05:44:40 +0100
User-agent: Mutt/1.5.13 (2006-08-11)


On Tue, Jan 02, 2007 at 12:19:44PM +0100, Thomas Schwinge wrote:

> > 2006-12-30  Richard Braun  <syn@hurdfr.org>
> > 
> >     Added alignment support in the zone allocator.
> > 
> >     * kern/zalloc.c (ALIGN_SIZE_UP): New macro.

> In general (also for Samuel): you don't have to write these
> introductory lines if it is understandable from the following block of
> changes what the patch is doing.  But it doesn't hurt either.  :-)

Actually, such a description is extremely useful, and IMHO much more
important than the detailed listing of changes. When using version
control, the code changes can be seen from the diffs pretty easiliy.
It's much more important to explain in the changlog *why* things were
changed -- this is what CVS can't tell you, and takes a lot of trouble
to guess from the code changes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]