|
From: | zhengda |
Subject: | Re: The patch of glibc which allows the user to override the pfinet server |
Date: | Thu, 26 Jun 2008 19:31:12 +0200 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080421) |
olafBuddenhagen@gmx.net wrote:
I think using the symbolic link to the default server is another a solution.Hi, On Wed, Jun 25, 2008 at 04:44:51PM +0200, zhengda wrote:Neal H. Walfield wrote:Yes of course. If we want to override the TCP/IP stack, that doesn't mean we want to override the pipe server as well, or the other way round...
Do you mean the indentation here? It is caused by '-' and '+' in the beginning of lines.server = __file_name_lookup (np, 0, 0); if (domain <= max_domain) - servers[domain] = server; + servers[domain] = server; + if (name) + free(name);
There is no problem in the code.
Hm... Something seems wrong with the indentation here -- but it looks as if it has been already wrong in the original code... Can you fix that please? Oh, and of course you still need a changelog entry. There is a section in the GCS on that as well...
Where should I write the changelog? in the patch? Best, Zheng Da
[Prev in Thread] | Current Thread | [Next in Thread] |