[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The patch of glibc which allows the user to override the pfinet serv
|
From: |
Samuel Thibault |
|
Subject: |
Re: The patch of glibc which allows the user to override the pfinet server |
|
Date: |
Fri, 11 Jul 2008 01:24:47 +0100 |
|
User-agent: |
Mutt/1.5.12-2006-07-14 |
Hello,
> + char sock_serv_env_name[30];
To avoid a fixed-sized buffer you could use __asprintf.
> + name = (char *)malloc (len + 100);
Use __asprintf here too.
> - servers[domain] = server;
> + servers[domain] = server;
Spurious hook, please try to minimize these.
About the ChangeLog entry, it needs to be more precise: add the
environment variable and macro _names_ since that's what people would
grep for.
Samuel