[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The patch of pfinet

From: zhengda
Subject: Re: The patch of pfinet
Date: Wed, 13 Aug 2008 12:07:50 +0200
User-agent: Thunderbird (X11/20080707)

olafBuddenhagen@gmx.net wrote:
+      master_device = file_name_lookup (master_device_file , 0 , 0);
+      if (master_device == MACH_PORT_NULL)
+        error (2, 0, "file_name_lookup %s", master_device_file);

Doesn't file_name_lookup() set errno?...
The funny thing here is that gcc always complains that it cannot find the definition of errno even though I have included errno.h.
          for (in = h->interfaces; in < h->interfaces + h->num_interfaces; in++)
-           if (strcmp (in->device->name, arg) == 0)
+            if (strcmp (in->name, arg) == 0)

Wrong indentation.
I think the problem is that my vim always uses space instead of tab. and the displaying result also depends on how your editor display tab.
The tab stops 8 columns in my vim.

Zheng Da

reply via email to

[Prev in Thread] Current Thread [Next in Thread]