[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] unionfs now builds successfully

From: Thomas Schwinge
Subject: Re: [PATCH 1/5] unionfs now builds successfully
Date: Wed, 27 May 2009 20:58:00 +0200
User-agent: Mutt/1.5.11


On Tue, May 26, 2009 at 11:31:49PM +0300, Sergiu Ivanov wrote:
> diff --git a/Makefile b/Makefile
> index b180072..3129031 100644
> --- a/Makefile
> +++ b/Makefile

Don't forget to update the list of copyright years.

> +# Get the information from under /usr.
> +prefix = /usr/

No trailing slash.

Ugly, but yeah.  Eventually, I plan to transition all that stuff to
Automake.  For the Hurd proper, there is already some work by Jeff Bailey
in that area and I also extended that, but one open issue is to teach
Automake to cooperate with mig (if interested, see the GNU Mach build
system for the gory details of how I'm doing this at the moment...) --
which is needed for unionfs: see the Makefile rules where this prefix
variable is used.

But for now, with these two changes I mentioned above, plus a proper
commit message (see again
``Behavior, Commit messages''), this is fine to be installed into
unionfs.git's master branch.  Please send your patch again, and then I'll
OK it for you to push into there.


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]