[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] Removed the ``add'' and ``remove'' options

From: olafBuddenhagen
Subject: Re: [PATCH 4/5] Removed the ``add'' and ``remove'' options
Date: Thu, 4 Jun 2009 01:50:21 +0200
User-agent: Mutt/1.5.18 (2008-05-17)


On Fri, May 29, 2009 at 12:08:06AM +0300, Sergiu Ivanov wrote:

> -    case OPT_ADD:            /* --add */
> -      ulfs_mode = ULFS_MODE_ADD;
> -      break;
> -
> -    case OPT_REMOVE:         /* --remove  */
> -      ulfs_mode = ULFS_MODE_REMOVE;
> -      break;
> -

You removed the options to actually switch the mode, but the handling of
the mode is still there, as dead code... You did remove it in the next
patch, but it really belongs here.

I think in a way this illustrates a more fundamental issue though: your
command line handling changes generally seem too cosmetic. They still
leave a lot of stuff that doesn't really make sense for unionmount: stow
can't work; priorities are pointless; both the underlying directory tree
and the mountee should be writable by default, and I'm not sure it's
useful to allow overriding them at all.

Basic unionmount really just needs a very simple command line: an option
to decide whether the mountee goes on top or below the underlying tree;
and the list of argements describing the translator to mount.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]