[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] unionfs now builds successfully

From: olafBuddenhagen
Subject: Re: [PATCH 1/5] unionfs now builds successfully
Date: Sat, 30 May 2009 16:39:48 +0200
User-agent: Mutt/1.5.18 (2008-05-17)


On Tue, May 26, 2009 at 11:31:49PM +0300, Sergiu Ivanov wrote:

> +# Get the information from under /usr.
> +prefix = /usr/

Do NOT hardcode the prefix -- it is a variable for a reason! The user
can change it by setting the environment variable. (For that same
reason, the title of the patch is wrong -- it was able to build before,
if used properly...)

A patch that picks /usr as *default* prefix, if the user hasn't set
anything explicitely, would be fine though.

Also, this is a patch for unionfs itself. It should not go into the
unionmount patch series. (Ideally, it would be commited to the unionfs
master branch before pushing anything to the unionmount branch -- this
way, you can branch after that change, and thus can avoid a merge.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]