[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #29655] linkat() fails because __file_name_lookup_at() problems

From: Carl Fredrik Hammar
Subject: [bug #29655] linkat() fails because __file_name_lookup_at() problems
Date: Tue, 27 Apr 2010 16:37:55 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100308 Iceweasel/3.5.8 (like Firefox/3.5.8)

Follow-up Comment #2, bug #29655 (project hurd):

The patch looks good, but I do have two minor suggestions.

First, I found the comment a bit confusing.  The "default" behavior is
determined by the O_NOLINK flag, and isn't something that is constant.
So perhaps you could change it to mention this, or better yet explain
the flags in terms of setting or clearing O_NOLINK.

Second, it is good that you check that both AT_SYMLINK_FOLLOW and
AT_SYMLINK_NOFOLLOW aren't set, but it is still possible to call `at`
functions with the wrong flag, e.g. `linkat(..., AT_SYMLINK_FOLLOW)`.
You could fix this by only allowing AT_SYMLINK_NOFOLLOW if O_NOLINK is
not set and AT_SYMLINK_FOLLOW if it is set.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]